Re: [PATCH 1/2] dt-bindings: leds: register-bit-led: Add active-low property
From: Pali Rohár
Date: Fri Aug 19 2022 - 05:11:36 EST
On Friday 19 August 2022 10:42:22 Pali Rohár wrote:
> On Friday 19 August 2022 11:38:29 Krzysztof Kozlowski wrote:
> > On 19/08/2022 11:08, Pavel Machek wrote:
> > > Hi!
> > >
> > >>> Although the question is - where is the user of it?
> > >>
> > >> I was planning to send updated powerpc DTS files with these
> > >> register-bit-led definitions after accepting dt bindings.
> > >
> > > We need device tree people to ack them, first. But a note saying "this
> > > is for Turris Omnia router" would be welcome.
> >
> > In general the process is one of:
> > 1. Send DT bindings with driver and DTS changes,
> > 2. Send DT bindings with driver in one patchset, DTS in second but you
> > mention the dependency.
> >
> > You should not wait with DTS till bindings got accepted. Why? Because
> > for example we do not want bindings for stuff which never is going to be
> > upstreamed (with several exceptions, e.g. for other systems). Also
> > because we want to be able to compare bindings with your DTS
> > implementing them, so we are sure you described everything (especially
> > that you said running one command to install dtchema and second command
> > to make the check is not possible in your system).
> >
> > Without DTS here how can anyone be sure your DTS actually follows the
> > bindings?
> >
> > Best regards,
> > Krzysztof
>
> Well, last time I was told that first needs to be accepted bindings
> documentation and then device tree files. So I did it like this. And now
> it is again feasible and different steps and ordering is needed...
> Sorry I cannot known all requirements which are moreover changing every
> day.
Here it is:
https://lore.kernel.org/linuxppc-dev/20220819084433.26011-1-pali@xxxxxxxxxx/