Re: [PATCH net-next 2/2] net: phy: tja11xx: add interface mode and RMII REF_CLK support
From: Andrew Lunn
Date: Fri Aug 19 2022 - 08:50:45 EST
> +/* Configure REF_CLK as input in RMII mode */
> +#define TJA110X_RMII_MODE_REFCLK_IN BIT(0)
> +
> struct tja11xx_priv {
> char *hwmon_name;
> struct device *hwmon_dev;
> struct phy_device *phydev;
> struct work_struct phy_register_work;
> + u32 quirks;
A quirk is generally a workaround for a bug. Configuring a clock is
not a quirk. I would rename this flags.
Andrew