Re: [PATCH] PCI: hv: Fix the definiton of vector in hv_compose_msi_msg()

From: Wei Liu
Date: Fri Aug 19 2022 - 12:04:16 EST


On Mon, Aug 15, 2022 at 03:35:45PM -0500, Bjorn Helgaas wrote:
> s/definiton/definition/ in subject
> (only if you have other occasion to repost this)
>
> On Mon, Aug 15, 2022 at 11:55:05AM -0700, Dexuan Cui wrote:
> > The local variable 'vector' must be u32 rather than u8: see the
> > struct hv_msi_desc3.
> >
> > 'vector_count' should be u16 rather than u8: see struct hv_msi_desc,
> > hv_msi_desc2 and hv_msi_desc3.
> >
> > Fixes: a2bad844a67b ("PCI: hv: Fix interrupt mapping for multi-MSI")
> > Signed-off-by: Dexuan Cui <decui@xxxxxxxxxxxxx>
> > Cc: Jeffrey Hugo <quic_jhugo@xxxxxxxxxxx>
> > Cc: Carl Vanderlip <quic_carlv@xxxxxxxxxxx>
>
> Looks like Wei has been applying most changes to pci-hyperv.c, so I
> assume the same will happen here.

I can take care of this one via hyperv-fixes, but ...

>
> > ---
> >
> > The patch should be appplied after the earlier patch:
> > [PATCH] PCI: hv: Only reuse existing IRTE allocation for Multi-MSI
> > https://lwn.net/ml/linux-kernel/20220804025104.15673-1-decui%40microsoft.com/
> >

... this patch looks to be rejected.

Thanks,
Wei.