Re: [PATCH] regulator: core: Clean up on enable failure

[Doug Anderson]

Hi,

On Fri, Aug 19, 2022 at 3:48 PM Mark Brown <broonie@xxxxxxxxxx> wrote:
>
> On Fri, Aug 19, 2022 at 02:43:36PM -0500, Andrew Halaney wrote:
>
> > -     if (regulator->uA_load && regulator->enable_count == 1)
> > -             return drms_uA_update(rdev);
> > +     if (regulator->uA_load && regulator->enable_count == 1) {
> > +             ret = drms_uA_update(rdev);
>
> I am vaugely surprised and a bit concerned that drms_uA_update() can
> fail...

In his original email Andrew implied that his system was misconfigured
when he was seeing this error. I presume this isn't common which is
why nobody had noticed this before now, but given that the function
drms_uA_update() does return an error code it seems like we should
handle it properly in the caller.

-Doug