Re: [PATCH 2/4] tracing/eprobes: Do not hardcode $comm as a string

[Google]

On Sat, 20 Aug 2022 09:00:38 -0400
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> On Sat, 20 Aug 2022 08:48:37 -0400
> Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> 
> >  I should probably make "$common_comm" used too.
> 
> 
> My mistake. It was "common_cpu" not "common_comm". The filter and histogram
> just use "comm" or "COMM". I'll leave this as it.

Yeah, this is a bit confusing me. histogram allows common_cpu but filter allows
only CPU. Shouldn't we unify those?

Thanks,

> 
> -- Steve
> 


-- 
Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>