Re: [PATCH v5 6/7] remoteproc: qcom: Add support for memory sandbox
From: kernel test robot
Date: Sat Aug 20 2022 - 09:53:02 EST
Hi Srinivasa,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on remoteproc/rproc-next]
[also build test WARNING on linus/master v6.0-rc1 next-20220819]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Srinivasa-Rao-Mandadapu/Update-ADSP-pil-loader-for-SC7280-platform/20220816-195318
base: git://git.kernel.org/pub/scm/linux/kernel/git/remoteproc/linux.git rproc-next
config: arm64-allyesconfig (https://download.01.org/0day-ci/archive/20220820/202208202105.f6q5X3x5-lkp@xxxxxxxxx/config)
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project c9a41fe60ab62f7a40049c100adcc8087a47669b)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/intel-lab-lkp/linux/commit/04dc00863cb7b62aa7e5356f81cad5e7720e17ad
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Srinivasa-Rao-Mandadapu/Update-ADSP-pil-loader-for-SC7280-platform/20220816-195318
git checkout 04dc00863cb7b62aa7e5356f81cad5e7720e17ad
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/interconnect/imx/ drivers/remoteproc/ drivers/thunderbolt/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All warnings (new ones prefixed by >>):
>> drivers/remoteproc/qcom_q6v5_adsp.c:442:54: warning: format specifies type 'void *' but the argument has type 'u32' (aka 'unsigned int') [-Wformat]
pr_err("failed to map addr = %p mem_size = %x\n", rsc_fw->pa, rsc_fw->len);
~~ ^~~~~~~~~~
%u
include/linux/printk.h:518:33: note: expanded from macro 'pr_err'
printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
~~~ ^~~~~~~~~~~
include/linux/printk.h:475:60: note: expanded from macro 'printk'
#define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
~~~ ^~~~~~~~~~~
include/linux/printk.h:447:19: note: expanded from macro 'printk_index_wrap'
_p_func(_fmt, ##__VA_ARGS__); \
~~~~ ^~~~~~~~~~~
1 warning generated.
vim +442 drivers/remoteproc/qcom_q6v5_adsp.c
422
423 static int adsp_rproc_map_smmu(struct rproc *rproc, int len)
424 {
425 struct fw_rsc_devmem *rsc_fw;
426 struct fw_rsc_hdr *hdr;
427 int offset;
428 int ret;
429 int i;
430
431 if (!rproc->table_ptr)
432 return 0;
433
434 for (i = 0; i < rproc->table_ptr->num; i++) {
435 offset = rproc->table_ptr->offset[i];
436 hdr = (void *)rproc->table_ptr + offset;
437 rsc_fw = (struct fw_rsc_devmem *)hdr + sizeof(*hdr);
438
439 ret = iommu_map(rproc->domain, rsc_fw->da, rsc_fw->pa,
440 rsc_fw->len, rsc_fw->flags);
441 if (ret) {
> 442 pr_err("failed to map addr = %p mem_size = %x\n", rsc_fw->pa, rsc_fw->len);
443 goto rproc_smmu_unmap;
444 }
445 }
446
447 return 0;
448
449 rproc_smmu_unmap:
450 adsp_rproc_unmap_smmu(rproc, i);
451 return ret;
452 }
453
--
0-DAY CI Kernel Test Service
https://01.org/lkp