Re: [PATCH v1] selinux/ss/services.c: check the return value of audit_log_start() in security_sid_mls_copy()

From: Paul Moore
Date: Sat Aug 20 2022 - 10:20:07 EST


On Sat, Aug 20, 2022 at 4:26 AM lily <floridsleeves@xxxxxxxxx> wrote:
>
> The function audit_log_start() can fail, so its return value should be
> checked against NULL.
>
> Signed-off-by: Li Zhong <floridsleeves@xxxxxxxxx>
> ---
> security/selinux/ss/services.c | 3 +++
> 1 file changed, 3 insertions(+)

audit_log_start() can safely return NULL as the audit_log_*()
functions are designed to handle a NULL audit_buffer. This is an
expected behavior and not a bug.

--
paul-moore.com