Re: [PATCH v2 05/11] hexagon: mm: Convert to GENERIC_IOREMAP
From: Christoph Hellwig
Date: Sun Aug 21 2022 - 03:01:29 EST
On Sat, Aug 20, 2022 at 08:31:19AM +0800, Baoquan He wrote:
> With it, the old ioremap() and iounmap() can be perfectly removed
> since they are duplicated with the standard functions.
Can you write a somewhat better commit message explaining that it
switches to the generic code that has equivalent functionality?
> +#define ioremap_uc(addr, size) ioremap((addr), (size))
This is wrong and hexagon should use the asm-generic version of
ioremap_uc that returns NULL.