Re: [PATCH] IB: move from strlcpy with unused retval to strscpy

From: Leon Romanovsky
Date: Sun Aug 21 2022 - 07:18:27 EST


On Thu, Aug 18, 2022 at 11:00:18PM +0200, Wolfram Sang wrote:
> Follow the advice of the below link and prefer 'strscpy' in this
> subsystem. Conversion is 1:1 because the return value is not used.
> Generated by a coccinelle script.
>
> Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@xxxxxxxxxxxxxx/
> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
> ---
> drivers/infiniband/core/cma_configfs.c | 2 +-
> drivers/infiniband/core/device.c | 4 ++--
> drivers/infiniband/hw/bnxt_re/main.c | 2 +-
> drivers/infiniband/hw/hfi1/file_ops.c | 2 +-
> drivers/infiniband/hw/hfi1/verbs.c | 2 +-
> drivers/infiniband/hw/mthca/mthca_cmd.c | 2 +-
> drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 2 +-
> drivers/infiniband/hw/qib/qib_iba7322.c | 2 +-
> drivers/infiniband/ulp/ipoib/ipoib_ethtool.c | 4 ++--
> drivers/infiniband/ulp/opa_vnic/opa_vnic_ethtool.c | 4 ++--
> drivers/infiniband/ulp/srpt/ib_srpt.c | 2 +-
> 11 files changed, 14 insertions(+), 14 deletions(-)

You forgot to change strlcpy in include/rdma/rdma_vt.h file.

I changed locally and applied to -next.

Thanks