Re: [PATCH 5.10 000/541] 5.10.137-rc2 review

[Greg Kroah-Hartman]

On Sun, Aug 21, 2022 at 05:03:48AM -0700, Guenter Roeck wrote:
> On Sat, Aug 20, 2022 at 08:39:26PM +0200, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 5.10.137 release.
> > There are 541 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> > 
> > Responses should be made by Mon, 22 Aug 2022 18:28:24 +0000.
> > Anything received after that time might be too late.
> > 
> Build results:
> 	total: 163 pass: 162 fail: 1
> Failed builds:
> 	um:defconfig
> Qemu test results:
> 	total: 474 pass: 474 fail: 0
> 
> The build error is:
> 
> Building um:defconfig ... failed
> --------------
> Error log:
> In file included from arch/um/include/shared/irq_user.h:10,
>                  from arch/um/include/shared/os.h:12,
>                  from arch/um/kernel/umid.c:9:
> include/linux/stddef.h:11:9: error: expected identifier before numeric constant
>    11 |         false   = 0,
>       |         ^~~~~
> include/linux/types.h:30:33: error: two or more data types in declaration specifiers
>    30 | typedef _Bool                   bool;
>       |                                 ^~~~
> In file included from arch/um/include/shared/os.h:17,
>                  from arch/um/kernel/umid.c:9:
> include/linux/types.h:30:1: warning: useless type name in empty declaration
>    30 | typedef _Bool                   bool;
>       | ^~~~~~~
> 
> Bisect points to commit 6660dd43bbf ("um: seed rng using host OS rng"),
> and reverting it fixes the problem.

Thanks, I'll go drop that commit now.

greg k-h