drivers/gpu/drm/amd/amdgpu/../pm/swsmu/amdgpu_smu.c:139 smu_set_gfx_power_up_by_imu() error: we previously assumed 'smu->ppt_funcs' could be null (see line 139)
From: Dan Carpenter
Date: Mon Aug 22 2022 - 02:43:41 EST
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 573ae4f13f630d6660008f1974c0a8a29c30e18a
commit: 7101ab97e3b00ec1c68d09826bb0521d17783673 drm/amdgpu/pm: implement the SMU_MSG_EnableGfxImu function
config: ia64-randconfig-m031-20220814 (https://download.01.org/0day-ci/archive/20220819/202208190418.1Y3QCIis-lkp@xxxxxxxxx/config)
compiler: ia64-linux-gcc (GCC) 12.1.0
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>
Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
smatch warnings:
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/amdgpu_smu.c:139 smu_set_gfx_power_up_by_imu() error: we previously assumed 'smu->ppt_funcs' could be null (see line 139)
vim +139 drivers/gpu/drm/amd/amdgpu/../pm/swsmu/amdgpu_smu.c
7101ab97e3b00ec drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c Huang Rui 2022-05-18 137 int smu_set_gfx_power_up_by_imu(struct smu_context *smu)
7101ab97e3b00ec drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c Huang Rui 2022-05-18 138 {
7101ab97e3b00ec drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c Huang Rui 2022-05-18 @139 if (!smu->ppt_funcs && !smu->ppt_funcs->set_gfx_power_up_by_imu)
^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
This should be ||. If smu->ppt_funcs is NULL the code will crash.
7101ab97e3b00ec drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c Huang Rui 2022-05-18 140 return -EOPNOTSUPP;
7101ab97e3b00ec drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c Huang Rui 2022-05-18 141
7101ab97e3b00ec drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c Huang Rui 2022-05-18 142 return smu->ppt_funcs->set_gfx_power_up_by_imu(smu);
7101ab97e3b00ec drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c Huang Rui 2022-05-18 143 }
--
0-DAY CI Kernel Test Service
https://01.org/lkp