Re: [PATCH] soc: qcom: qmi: use const for struct qmi_elem_info
From: kernel test robot
Date: Mon Aug 22 2022 - 04:49:33 EST
Hi Jeff,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v6.0-rc2 next-20220822]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Jeff-Johnson/soc-qcom-qmi-use-const-for-struct-qmi_elem_info/20220822-144905
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 1c23f9e627a7b412978b4e852793c5e3c3efc555
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20220822/202208221632.bulgoDlE-lkp@xxxxxxxxx/config)
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/84f0de3071b40fad5e5a48ad27b16ce28f9210fb
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Jeff-Johnson/soc-qcom-qmi-use-const-for-struct-qmi_elem_info/20220822-144905
git checkout 84f0de3071b40fad5e5a48ad27b16ce28f9210fb
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/soc/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All warnings (new ones prefixed by >>):
drivers/soc/qcom/qmi_encdec.c: In function 'skip_to_next_elem':
>> drivers/soc/qcom/qmi_encdec.c:94:16: warning: return discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
94 | return temp_ei;
| ^~~~~~~
vim +/const +94 drivers/soc/qcom/qmi_encdec.c
9b8a11e8261527 Bjorn Andersson 2017-12-05 59
84f0de3071b40f Jeff Johnson 2022-08-21 60 static int qmi_encode(const struct qmi_elem_info *ei_array, void *out_buf,
9b8a11e8261527 Bjorn Andersson 2017-12-05 61 const void *in_c_struct, u32 out_buf_len,
9b8a11e8261527 Bjorn Andersson 2017-12-05 62 int enc_level);
9b8a11e8261527 Bjorn Andersson 2017-12-05 63
84f0de3071b40f Jeff Johnson 2022-08-21 64 static int qmi_decode(const struct qmi_elem_info *ei_array, void *out_c_struct,
9b8a11e8261527 Bjorn Andersson 2017-12-05 65 const void *in_buf, u32 in_buf_len, int dec_level);
9b8a11e8261527 Bjorn Andersson 2017-12-05 66
9b8a11e8261527 Bjorn Andersson 2017-12-05 67 /**
9b8a11e8261527 Bjorn Andersson 2017-12-05 68 * skip_to_next_elem() - Skip to next element in the structure to be encoded
9b8a11e8261527 Bjorn Andersson 2017-12-05 69 * @ei_array: Struct info describing the element to be skipped.
9b8a11e8261527 Bjorn Andersson 2017-12-05 70 * @level: Depth level of encoding/decoding to identify nested structures.
9b8a11e8261527 Bjorn Andersson 2017-12-05 71 *
9b8a11e8261527 Bjorn Andersson 2017-12-05 72 * This function is used while encoding optional elements. If the flag
9b8a11e8261527 Bjorn Andersson 2017-12-05 73 * corresponding to an optional element is not set, then encoding the
9b8a11e8261527 Bjorn Andersson 2017-12-05 74 * optional element can be skipped. This function can be used to perform
9b8a11e8261527 Bjorn Andersson 2017-12-05 75 * that operation.
9b8a11e8261527 Bjorn Andersson 2017-12-05 76 *
9b8a11e8261527 Bjorn Andersson 2017-12-05 77 * Return: struct info of the next element that can be encoded.
9b8a11e8261527 Bjorn Andersson 2017-12-05 78 */
84f0de3071b40f Jeff Johnson 2022-08-21 79 static struct qmi_elem_info *skip_to_next_elem(const struct qmi_elem_info *ei_array,
9b8a11e8261527 Bjorn Andersson 2017-12-05 80 int level)
9b8a11e8261527 Bjorn Andersson 2017-12-05 81 {
84f0de3071b40f Jeff Johnson 2022-08-21 82 const struct qmi_elem_info *temp_ei = ei_array;
9b8a11e8261527 Bjorn Andersson 2017-12-05 83 u8 tlv_type;
9b8a11e8261527 Bjorn Andersson 2017-12-05 84
9b8a11e8261527 Bjorn Andersson 2017-12-05 85 if (level > 1) {
9b8a11e8261527 Bjorn Andersson 2017-12-05 86 temp_ei = temp_ei + 1;
9b8a11e8261527 Bjorn Andersson 2017-12-05 87 } else {
9b8a11e8261527 Bjorn Andersson 2017-12-05 88 do {
9b8a11e8261527 Bjorn Andersson 2017-12-05 89 tlv_type = temp_ei->tlv_type;
9b8a11e8261527 Bjorn Andersson 2017-12-05 90 temp_ei = temp_ei + 1;
9b8a11e8261527 Bjorn Andersson 2017-12-05 91 } while (tlv_type == temp_ei->tlv_type);
9b8a11e8261527 Bjorn Andersson 2017-12-05 92 }
9b8a11e8261527 Bjorn Andersson 2017-12-05 93
9b8a11e8261527 Bjorn Andersson 2017-12-05 @94 return temp_ei;
9b8a11e8261527 Bjorn Andersson 2017-12-05 95 }
9b8a11e8261527 Bjorn Andersson 2017-12-05 96
--
0-DAY CI Kernel Test Service
https://01.org/lkp