Re: [PATCH] mm/hugetlb: remove unused local variable dst_entry in copy_hugetlb_page_range()

[Lukas Bulwahn]

On Mon, Aug 22, 2022 at 10:51 AM Miaohe Lin <linmiaohe@xxxxxxxxxx> wrote:
>
> On 2022/8/22 16:25, Lukas Bulwahn wrote:
> > Commit a0e4f7b82610 ("mm/hugetlb: make detecting shared pte more reliable")
> > modifies copy_hugetlb_page_range() such that huge_ptep_get(dst_pte) and the
> > local variable dst_entry is not used explicitly in this function.
> >
> > Remove this unused local variable dst_entry in copy_hugetlb_page_range().
> > No functional change.
> >
> > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@xxxxxxxxx>
>
> LGTM. Thanks for your patch.
>
> Reviewed-by: Miaohe Lin <linmiaohe@xxxxxxxxxx>
>
> BTW: I will send a v2 of that series soon. So the above commit id might change.
>

Feel free to just squash this code improvement into your next v2 patch.

Lukas