Re: [PATCH v6 1/1] gpio: mpfs: add polarfire soc gpio support

[Linus Walleij]

On Mon, Aug 15, 2022 at 2:08 PM <lewis.hanly@xxxxxxxxxxxxx> wrote:

> From: Lewis Hanly <lewis.hanly@xxxxxxxxxxxxx>
>
> Add a driver to support the Polarfire SoC gpio controller
>
> Signed-off-by: Lewis Hanly <lewis.hanly@xxxxxxxxxxxxx>

This looks like  textbook example of a driver that can use
CONFIG_GPIO_GENERIC

> +config GPIO_POLARFIRE_SOC
> +       bool "Microchip FPGA GPIO support"
> +       depends on OF_GPIO
> +       select GPIOLIB_IRQCHIP

select GPIO_GENERIC

See e.g. drivers/gpio/gpio-ftgpio010.c for an example
of how to use bgpio_init() to set up the helper library to handle
the GPIO side of things and combine it with an irqchip.
You get get/set_multiple() for free with this approach.
Also see documentation for bgpio_init() in
drivers/gpio/gpio-mmio.c.

Yours,
Linus Walleij