Re: [PATCH v4 2/2] cpufreq: CPPC: Change FIE default

[Lukasz Luba]

On 8/19/22 17:25, Jeremy Linton wrote:
> FIE is mostly implemented as PCC mailboxes on arm machines.  This was
> enabled by default without any data suggesting that it does anything
> but hurt system performance. Lets change the default to 'n' until
> hardware appears which clearly benefits.
>
> Signed-off-by: Jeremy Linton <jeremy.linton@xxxxxxx>
> ---
>   drivers/cpufreq/Kconfig.arm | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
> index 954749afb5fe..ad66d8f15db0 100644
> --- a/drivers/cpufreq/Kconfig.arm
> +++ b/drivers/cpufreq/Kconfig.arm
> @@ -22,7 +22,7 @@ config ACPI_CPPC_CPUFREQ
>   config ACPI_CPPC_CPUFREQ_FIE
>   	bool "Frequency Invariance support for CPPC cpufreq driver"
>   	depends on ACPI_CPPC_CPUFREQ && GENERIC_ARCH_TOPOLOGY
> -	default y
> +	default n
>   	help
>   	  This extends frequency invariance support in the CPPC cpufreq driver,
>   	  by using CPPC delivered and reference performance counters.

LGTM

Reviewed-by: Lukasz Luba <lukasz.luba@xxxxxxx>