Re: [PATCH 3/3] memcg: increase MEMCG_CHARGE_BATCH to 64
From: Shakeel Butt
Date: Mon Aug 22 2022 - 11:14:26 EST
On Mon, Aug 22, 2022 at 3:47 AM Michal Hocko <mhocko@xxxxxxxx> wrote:
>
[...]
>
> > To evaluate the impact of this optimization, on a 72 CPUs machine, we
> > ran the following workload in a three level of cgroup hierarchy with top
> > level having min and low setup appropriately. More specifically
> > memory.min equal to size of netperf binary and memory.low double of
> > that.
>
> a similar feedback to the test case description as with other patches.
What more info should I add to the description? Why did I set up min
and low or something else?
> >
> > $ netserver -6
> > # 36 instances of netperf with following params
> > $ netperf -6 -H ::1 -l 60 -t TCP_SENDFILE -- -m 10K
> >
> > Results (average throughput of netperf):
> > Without (6.0-rc1) 10482.7 Mbps
> > With patch 17064.7 Mbps (62.7% improvement)
> >
> > With the patch, the throughput improved by 62.7%.
> >
> > Signed-off-by: Shakeel Butt <shakeelb@xxxxxxxxxx>
> > Reported-by: kernel test robot <oliver.sang@xxxxxxxxx>
>
> Anyway
> Acked-by: Michal Hocko <mhocko@xxxxxxxx>
Thanks