RE: [PATCH] cxl: Replace HDM decoder granularity magic numbers

From: Dan Williams
Date: Mon Aug 22 2022 - 13:34:57 EST


Adam Manzanares wrote:
> When reviewing the CFMWS parsing code that deals with the HDM decoders,
> I noticed a couple of magic numbers. This commit replaces these magic numbers
> with constants defined by the CXL 2.0 specification.

I have a small quibble with CXL_DECODER_MAX_GRANULARITY_ORDER. How about
CXL_DECODER_MAX_ENCODED_IG? Because the value is not the 'power of 2
order' it's the 'power of 2 order - 8'.