Re: [PATCH v2 0/3] Adding support for trace events to habanalabs

[Oded Gabbay]

On Mon, Aug 22, 2022 at 5:52 PM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
>
> On Sun, 21 Aug 2022 11:06:05 +0300
> Oded Gabbay <ogabbay@xxxxxxxxxx> wrote:
>
> > Thanks for your comments. We have fixed the patches according to them.
> >
> > You wrote the first patch is r-b, but I took the liberty to add your r-b to
> > all three patches, I hope you don't object.
>
> I usually only add the r-b to the patches that add TRACE_EVENT(), and
> sometimes to those that modify them. Because that's what I know best. The
> usage of the trace events is usually subsystem specific and I tend not to
> add a r-b for them because people might think I understand how they are
> being used ;-)
>
> But in this case, since I did recommend some tricks in those extra patches,
> you can keep the tag for them.
>
> Here's my disclaimer for all these patches:
>
> ***
>
> Reviewed only from the tracing point of view, I have no idea if the content
> held in the trace is correct or not.
>
> ***
>
> ;-)
>
> -- Steve

Disclaimer duly noted Steve ;-)
Thanks for the review.

Oded