Re: [PATCH] arm64: dts: rockchip: Pull up wlan wake# on Gru-Bob

[Doug Anderson]

Hi,

On Mon, Aug 22, 2022 at 4:45 PM Brian Norris <briannorris@xxxxxxxxxxxx> wrote:
>
> The Gru-Bob board does not have a pull-up resistor on its
> WLAN_HOST_WAKE# pin, but Kevin does. The production/vendor kernel
> specified the pin configuration correctly as a pull-up, but this didn't
> get ported correctly to upstream.
>
> This means Bob's WLAN_HOST_WAKE# pin is floating, causing inconsistent
> wakeup behavior.
>
> Note that bt_host_wake_l has a similar dynamic, but apparently the
> upstream choice was to redundantly configure both internal and external
> pull-up on Kevin (see the "Kevin has an external pull up" comment in
> rk3399-gru.dtsi). This doesn't cause any functional problem, although
> it's perhaps wasteful.
>
> Fixes: 8559bbeeb849 ("arm64: dts: rockchip: add Google Bob")
> Signed-off-by: Brian Norris <briannorris@xxxxxxxxxxxx>
> ---
>
>  arch/arm64/boot/dts/rockchip/rk3399-gru-bob.dts         | 5 +++++
>  arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi | 1 +
>  2 files changed, 6 insertions(+)

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>