[PATCH v2 6/6] tty: n_gsm: add debug bit for user payload

From: D. Starke
Date: Tue Aug 23 2022 - 02:25:41 EST


From: Daniel Starke <daniel.starke@xxxxxxxxxxx>

A debug bit to output a complete transmission dump exists. Sometimes only
the user frames are relevant. Add an additional bit which limits the
transmission dump output to user data frames if set.

Signed-off-by: Daniel Starke <daniel.starke@xxxxxxxxxxx>
---
drivers/tty/n_gsm.c | 5 +++++
1 file changed, 5 insertions(+)

No changes since v1.

diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
index fcf2d52d5095..f3f0668f0a73 100644
--- a/drivers/tty/n_gsm.c
+++ b/drivers/tty/n_gsm.c
@@ -69,6 +69,7 @@ module_param(debug, int, 0600);
#define DBG_DATA (1 << 2) /* Data transmission details. */
#define DBG_ERRORS (1 << 3) /* Details for fail conditions. */
#define DBG_TTY (1 << 4) /* Transmission statistics for DLCI TTYs. */
+#define DBG_PAYLOAD (1 << 5) /* Limits DBG_DUMP to payload frames. */

/* Defaults: these are from the specification */

@@ -598,6 +599,10 @@ static void gsm_print_packet(const char *hdr, int addr, int cr,
{
if (!(debug & DBG_DUMP))
return;
+ /* Only show user payload frames if debug & DBG_PAYLOAD */
+ if (!(debug & DBG_PAYLOAD) && addr != 0)
+ if ((control & ~PF) == UI || (control & ~PF) == UIH)
+ return;

pr_info("%s %d) %c: ", hdr, addr, "RC"[cr]);

--
2.34.1