Re: [RFC PATCH v2 3/4] ARM: dts: stm32: add pin map for CAN controller on stm32f4

From: Krzysztof Kozlowski
Date: Tue Aug 23 2022 - 13:21:51 EST


On 20/08/2022 11:29, Dario Binacchi wrote:
> Add pin configurations for using CAN controller on stm32f469-disco
> board. They are located on the Arduino compatible connector CN5 (CAN1)
> and on the extension connector CN12 (CAN2).
>
> Signed-off-by: Dario Binacchi <dariobin@xxxxxxxxx>
> Signed-off-by: Dario Binacchi <dario.binacchi@xxxxxxxxxxxxxxxxxxxx>

Do not ignore review. This is not correct. You are mixing copyright with
SoC...

>


> + can2_pins_b: can2-1 {
> + pins1 {
> + pinmux = <STM32_PINMUX('B', 13, AF9)>; /* CAN2_TX */
> + };
> + pins2 {
> + pinmux = <STM32_PINMUX('B', 12, AF9)>; /* CAN2_RX */
> + bias-pull-up;
> + };
> + };
> +

Don't ignore review.

That's second one, so that's a no.. :(

Best regards,
Krzysztof