Re: [PATCH v4 13/17] mm/sl[au]b: cleanup kmem_cache_alloc[_node]_trace()

[Vlastimil Babka]

On 8/17/22 12:18, Hyeonggon Yoo wrote:
> This patch does:

I've removed this line locally and re-idented the rest.

> 	- Despite its name, kmem_cache_alloc[_node]_trace() is hook for
> 	  inlined kmalloc. So rename it to kmalloc[_node]_trace().
> 
> 	- Move its implementation to slab_common.c by using
>           __kmem_cache_alloc_node(), but keep CONFIG_TRACING=n varients to
> 	  save a function call when CONFIG_TRACING=n.
> 
> 	- Use __assume_kmalloc_alignment for kmalloc[_node]_trace
> 	  instead of __assume_slab_alignement. Generally kmalloc has
> 	  larger alignment requirements.
> 
> Suggested-by: Vlastimil Babka <vbabka@xxxxxxx>
> Signed-off-by: Hyeonggon Yoo <42.hyeyoo@xxxxxxxxx>

Reviewed-by: Vlastimil Babka <vbabka@xxxxxxx>