Re: [PATCH v1 1/2] perf stat: Clear reset_group for each stat run
From: Arnaldo Carvalho de Melo
Date: Tue Aug 23 2022 - 15:42:55 EST
Em Tue, Aug 23, 2022 at 05:10:55PM +0200, Andi Kleen escreveu:
>
> On 8/22/2022 11:33 PM, Ian Rogers wrote:
> > If a weak group is broken then the reset_group flag remains set for
> > the next run. Having reset_group set means the counter isn't created
> > and ultimately a segfault.
> >
> > A simple reproduction of this is:
> > perf stat -r2 -e '{cycles,cycles,cycles,cycles,cycles,cycles,cycles,cycles,cycles,cycles}:W
> > which will be added as a test in the next patch.
> >
> > Fixes: 4804e0111662 ("perf stat: Use affinity for opening events")
> > Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>
>
>
> Makes sense
>
>
> Reviewed-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>
Ok, applied.
- Arnaldo