Re: [RFT PATCH] regulator: core: Require regulator drivers to check uV for get_optimum_mode()

From: Mark Brown
Date: Tue Aug 23 2022 - 18:49:51 EST


On Tue, Aug 23, 2022 at 03:32:44PM -0700, Doug Anderson wrote:

> I guess maybe we could add the "initial mode" as an implicitly allowed
> mode? I guess the other option is to implicitly disable
> regulator-allow-set-load if no allowed modes are listed? Both of these

We should do the former, or equivalently just noop out of set_load() via
set_optimium_mode() if no modes are allowed.

> I guess the other option would be to say that if
> "regulator-allow-set-load" is set but not "regulator-allowed-modes"
> then we allow all modes? Somehow that doesn't seem like the "safest"
> option, though.

Yes, I'd prefer to avoid that.

Attachment: signature.asc
Description: PGP signature