Re: [PATCH 18/20] EDAC/synopsys: Drop unused platform-specific setup API
From: kernel test robot
Date: Tue Aug 23 2022 - 19:43:48 EST
Hi Serge,
I love your patch! Perhaps something to improve:
[auto build test WARNING on ras/edac-for-next]
[also build test WARNING on robh/for-next linus/master v6.0-rc2 next-20220823]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Serge-Semin/EDAC-mc-synopsys-Various-fixes-and-cleanups/20220823-031020
base: https://git.kernel.org/pub/scm/linux/kernel/git/ras/ras.git edac-for-next
config: arm-buildonly-randconfig-r006-20220823 (https://download.01.org/0day-ci/archive/20220824/202208240709.CwTZS8Qo-lkp@xxxxxxxxx/config)
compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/ec4a1d5280959bf5c6ff8d63006c62d54e01f9cc
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Serge-Semin/EDAC-mc-synopsys-Various-fixes-and-cleanups/20220823-031020
git checkout ec4a1d5280959bf5c6ff8d63006c62d54e01f9cc
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/edac/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All warnings (new ones prefixed by >>):
drivers/edac/synopsys_edac.c: In function 'synps_get_dtype':
drivers/edac/synopsys_edac.c:485:18: error: implicit declaration of function 'FIELD_GET'; did you mean 'FOLL_GET'? [-Werror=implicit-function-declaration]
485 | regval = FIELD_GET(DDR_MSTR_DEV_CFG_MASK, regval);
| ^~~~~~~~~
| FOLL_GET
drivers/edac/synopsys_edac.c: In function 'mc_init':
>> drivers/edac/synopsys_edac.c:600:33: warning: variable 'priv' set but not used [-Wunused-but-set-variable]
600 | struct synps_edac_priv *priv;
| ^~~~
cc1: some warnings being treated as errors
vim +/priv +600 drivers/edac/synopsys_edac.c
ae9b56e3996dadb Punnaiah Choudary Kalluri 2015-01-06 588
ae9b56e3996dadb Punnaiah Choudary Kalluri 2015-01-06 589 /**
225af74d6312b2a Manish Narani 2018-10-04 590 * mc_init - Initialize one driver instance.
225af74d6312b2a Manish Narani 2018-10-04 591 * @mci: EDAC memory controller instance.
225af74d6312b2a Manish Narani 2018-10-04 592 * @pdev: platform device.
ae9b56e3996dadb Punnaiah Choudary Kalluri 2015-01-06 593 *
225af74d6312b2a Manish Narani 2018-10-04 594 * Perform initialization of the EDAC memory controller instance and
ae9b56e3996dadb Punnaiah Choudary Kalluri 2015-01-06 595 * related driver-private data associated with the memory controller the
ae9b56e3996dadb Punnaiah Choudary Kalluri 2015-01-06 596 * instance is bound to.
ae9b56e3996dadb Punnaiah Choudary Kalluri 2015-01-06 597 */
fa9f6b9e1cf9620 Manish Narani 2018-10-04 598 static void mc_init(struct mem_ctl_info *mci, struct platform_device *pdev)
ae9b56e3996dadb Punnaiah Choudary Kalluri 2015-01-06 599 {
ae9b56e3996dadb Punnaiah Choudary Kalluri 2015-01-06 @600 struct synps_edac_priv *priv;
ae9b56e3996dadb Punnaiah Choudary Kalluri 2015-01-06 601
ae9b56e3996dadb Punnaiah Choudary Kalluri 2015-01-06 602 mci->pdev = &pdev->dev;
ae9b56e3996dadb Punnaiah Choudary Kalluri 2015-01-06 603 priv = mci->pvt_info;
ae9b56e3996dadb Punnaiah Choudary Kalluri 2015-01-06 604 platform_set_drvdata(pdev, mci);
ae9b56e3996dadb Punnaiah Choudary Kalluri 2015-01-06 605
ae9b56e3996dadb Punnaiah Choudary Kalluri 2015-01-06 606 /* Initialize controller capabilities and configuration */
ae9b56e3996dadb Punnaiah Choudary Kalluri 2015-01-06 607 mci->mtype_cap = MEM_FLAG_DDR3 | MEM_FLAG_DDR2;
ae9b56e3996dadb Punnaiah Choudary Kalluri 2015-01-06 608 mci->edac_ctl_cap = EDAC_FLAG_NONE | EDAC_FLAG_SECDED;
5cfa57cc8481722 Serge Semin 2022-08-22 609 mci->scrub_cap = SCRUB_FLAG_HW_SRC;
ae9b56e3996dadb Punnaiah Choudary Kalluri 2015-01-06 610 mci->scrub_mode = SCRUB_NONE;
ae9b56e3996dadb Punnaiah Choudary Kalluri 2015-01-06 611
ae9b56e3996dadb Punnaiah Choudary Kalluri 2015-01-06 612 mci->edac_cap = EDAC_FLAG_SECDED;
ae9b56e3996dadb Punnaiah Choudary Kalluri 2015-01-06 613 mci->ctl_name = "synps_ddr_controller";
ae9b56e3996dadb Punnaiah Choudary Kalluri 2015-01-06 614 mci->dev_name = SYNPS_EDAC_MOD_STRING;
ae9b56e3996dadb Punnaiah Choudary Kalluri 2015-01-06 615 mci->mod_name = SYNPS_EDAC_MOD_VER;
ae9b56e3996dadb Punnaiah Choudary Kalluri 2015-01-06 616
b500b4a029d577c Manish Narani 2018-10-25 617 edac_op_state = EDAC_OPSTATE_INT;
b500b4a029d577c Manish Narani 2018-10-25 618
ae9b56e3996dadb Punnaiah Choudary Kalluri 2015-01-06 619 mci->ctl_page_to_phys = NULL;
ae9b56e3996dadb Punnaiah Choudary Kalluri 2015-01-06 620
fa9f6b9e1cf9620 Manish Narani 2018-10-04 621 init_csrows(mci);
ae9b56e3996dadb Punnaiah Choudary Kalluri 2015-01-06 622 }
ae9b56e3996dadb Punnaiah Choudary Kalluri 2015-01-06 623
--
0-DAY CI Kernel Test Service
https://01.org/lkp