Re: [PATCH v2] tools: Add new "test" taint to kernel-chktaint

From: David Gow
Date: Wed Aug 24 2022 - 00:41:22 EST


On Wed, Aug 24, 2022 at 12:19 PM Joe Fradley <joefradley@xxxxxxxxxx> wrote:
>
> Commit c272612cb4a2 ("kunit: Taint the kernel when KUnit tests are run")
> added a new taint flag for when in-kernel tests run. This commit adds
> recognition of this new flag in kernel-chktaint.
>
> Reviewed-by: David Gow <davidgow@xxxxxxxxxx>
> Signed-off-by: Joe Fradley <joefradley@xxxxxxxxxx>
> ---
> Changes in v2:
> - based off of kselftest/kunit branch
> - Added David's Reviewed-by tag
>

This still looks good to me.

Unless anyone objects, I guess we'll take this through the KUnit
branch (which, after all, is where the taint was originally added).
I've added it to the list for 6.1, but it technically could be
considered a fix for 6.0 as well.

Cheers,
-- David

> tools/debugging/kernel-chktaint | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/tools/debugging/kernel-chktaint b/tools/debugging/kernel-chktaint
> index f1af27ce9f20..279be06332be 100755
> --- a/tools/debugging/kernel-chktaint
> +++ b/tools/debugging/kernel-chktaint
> @@ -187,6 +187,7 @@ else
> echo " * auxiliary taint, defined for and used by distros (#16)"
>
> fi
> +
> T=`expr $T / 2`
> if [ `expr $T % 2` -eq 0 ]; then
> addout " "
> @@ -195,6 +196,14 @@ else
> echo " * kernel was built with the struct randomization plugin (#17)"
> fi
>
> +T=`expr $T / 2`
> +if [ `expr $T % 2` -eq 0 ]; then
> + addout " "
> +else
> + addout "N"
> + echo " * an in-kernel test (such as a KUnit test) has been run (#18)"
> +fi
> +
> echo "For a more detailed explanation of the various taint flags see"
> echo " Documentation/admin-guide/tainted-kernels.rst in the Linux kernel sources"
> echo " or https://kernel.org/doc/html/latest/admin-guide/tainted-kernels.html";
> --
> 2.37.1.595.g718a3a8f04-goog
>

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature