Re: [PATCH v3] ARM: dts: lan966x: add support for pcb8290

[Nicolas Ferre]

Hi Horatiu,

On 24/08/2022 at 08:55, Horatiu Vultur wrote:
> Add basic support for pcb8290. It has 2 lan8814 phys(each phy is a
> quad-port) on the external MDIO bus and no SFP ports.
>
> Signed-off-by: Horatiu Vultur <horatiu.vultur@xxxxxxxxxxxxx>
> ---
> v2->v3:
> - update coma-mode-gpios, set them to OPEN_DRAIN
>
> v1->v2:
> - add comments for pps_out_pins and ptp_ext_pins pins
> - fix commit message.
> ---
>   arch/arm/boot/dts/Makefile            |   1 +
>   arch/arm/boot/dts/lan966x-pcb8290.dts | 171 ++++++++++++++++++++++++++
>   2 files changed, 172 insertions(+)
>   create mode 100644 arch/arm/boot/dts/lan966x-pcb8290.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 05d8aef6e5d2..595e870750cd 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -788,6 +788,7 @@ dtb-$(CONFIG_SOC_IMXRT) += \
>   dtb-$(CONFIG_SOC_LAN966) += \
>   	lan966x-kontron-kswitch-d10-mmt-6g-2gs.dtb \
>   	lan966x-kontron-kswitch-d10-mmt-8g.dtb \
> +	lan966x-pcb8290.dtb \
>   	lan966x-pcb8291.dtb \
>   	lan966x-pcb8309.dtb
>   dtb-$(CONFIG_SOC_LS1021A) += \
> diff --git a/arch/arm/boot/dts/lan966x-pcb8290.dts b/arch/arm/boot/dts/lan966x-pcb8290.dts
> new file mode 100644
> index 000000000000..3d93049fdf57
> --- /dev/null
> +++ b/arch/arm/boot/dts/lan966x-pcb8290.dts
> @@ -0,0 +1,171 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * lan966x_pcb8290.dts - Device Tree file for PCB8290

Copyright missing from this file. Can you apply the header model below?

// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
/*
  * Brief description goes here.
  *
  * Copyright (C) 2022 Microchip Technology Inc. and its subsidiaries
  *
  * Author: John Doe <john.doe@xxxxxxxxxxxxx>
  *
  * Longer description goes here.
  * Even on multiple lines.
  */

Maybe it's not align with other board files for lan966x, sorry if I 
didn't mention this earlier then ;-)

Regards,
  Nicolas

> + */
> +/dts-v1/;
> +#include "lan966x.dtsi"
> +#include "dt-bindings/phy/phy-lan966x-serdes.h"
> +
> +/ {
> +	model = "Microchip EVB LAN9668";
> +	compatible = "microchip,lan9668-pcb8290", "microchip,lan9668", "microchip,lan966";
> +
> +	gpio-restart {
> +		compatible = "gpio-restart";
> +		gpios = <&gpio 56 GPIO_ACTIVE_LOW>;
> +		priority = <200>;
> +	};
> +};

[..]

--
Nicolas Ferre