Re: [PATCH v10 0/6] Raspberry Pi Sense HAT driver

From: Stefan Wahren
Date: Wed Aug 24 2022 - 14:22:01 EST


Am 24.08.22 um 14:06 schrieb Charles Mirabile:
In case you want to send a new version it would be nice to enable the
driver in bcm2835_defconfig for better test coverage. But this is not a
show stopper.
Since I am going to have to send a v11 to fix Lee's email address I
will look into this. Is it as simple as adding another patch that puts
CONFIG_SENSEHAT_DISPLAY=y into the next version?
Presumably I would also want to enable CONFIG_JOYSTICK_SENSEHAT right?
Do I have to do anything special since both of those options have
decencies (namely CONFIG_I2C for both and CONFIG_INPUT for the latter,
and both select MFD_SIMPLE_MFD_I2C)?

make bcm2835_defconfig

enable both driver via make menuconfig

make savedefconfig

mv defconfig arch/arm/configs/bcm2835_defconfig.2

diff -u arch/arm/configs/bcm2835_defconfig arch/arm/configs/bcm2835_defconfig.2 > config.patch

manually add only the relevant changes from config.patch in arch/arm/configs/bcm2835_defconfig

generate the patch as usual

goal is to have simple patch which only contains the 2 driver changes without any clean-up changes