Re: [PATCH] HID: cp2112: Remove some dead code

[Jiri Kosina]

On Sat, 18 Jun 2022, Christophe JAILLET wrote:

> Commit 13de9cca514e ("HID: cp2112: add IRQ chip handling") has introduced
> cp2112_allocate_irq() that seems to be unused since 2016.
> 
> Remove it, remove the associated resources and part of the remove()
> function that frees the resources allocated in cp2112_allocate_irq().
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> ---
> Compile tested only.
> 
> Maybe the issue is completely elsewhere and the probe() should call
> cp2112_allocate_irq() in some cases.

Benjamin, could you please take a look? Apparently you were aware of the 
code being dead due to the __maybe_unused annotation ... :) What was the 
point?

Thanks,

-- 
Jiri Kosina
SUSE Labs