Re: [PATCH v2] drivers/virt/vSMP: new driver

[Dan Carpenter]

On Thu, Aug 25, 2022 at 06:24:02AM +0000, Czerwacki, Eial wrote:
> Introducing the vSMP guest driver which allows interaction with the
> vSMP control device when running a Linux OS atop of the vSMP hypervisor.
> vSMP is a resource aggregation hypervisor from SAP.
> 
> The driver comprises of api part which facilitates communication with
> the hypervisor and version which displays the hypervisor's version.
> 
> This patch s based on previous patches sent to the staging tree mailing
> lists
> 
> Signed-off-by: Eial Czerwacki <eial.czerwacki@xxxxxxx>
> Acked-by: Leonid Arsh <leonid.arsh@xxxxxxx>
> Acked-by: Oren Twaig <oren.twaig@xxxxxxx>
> CC: SAP vSMP Linux Maintainer <linux.vsmp@xxxxxxx>
> CC: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> CC: Arnd Bergmann <arnd@xxxxxxxx>
> CC: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> CC: Andra Paraschiv <andraprs@xxxxxxxxxx>
> CC: Borislav Petkov <bp@xxxxxxx>
> CC: Brijesh Singh <brijesh.singh@xxxxxxx>
> CC: Eric Biggers <ebiggers@xxxxxxxxxx>
> CC: Fei Li <fei1.li@xxxxxxxxx>
> CC: Hans de Goede <hdegoede@xxxxxxxxxx>
> CC: Jens Axboe <axboe@xxxxxxxxx>
> CC: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx>
> 
> v1 -> v2:
> 	- fix -0 var init in add_sysfs_entries (pointed out by Dan Carpenter)

Please don't resend patches the same day.  Always wait at least a day
but probably for a new driver wait 3 days.  There are going to be a lot
of comments on this.

My comment didn't even warrant a resend at all, it just something that
made me chuckle.  It will take a while to review this properly.

regards,
dan carpenter