Re: [PATCH] tools: Delete the initialization value

[Rafael J. Wysocki]

On Thu, Aug 25, 2022 at 11:04 AM shijm <junming@xxxxxxxxxxxx> wrote:
>
> From: Shi junming <junming@xxxxxxxxxxxx>
>
> From the perspective of commpier,delete the initialization value

I'm not sure what this means.

The initialization is unnecessary, because the variable in question is
always assigned a new value before reading it.  Is that what you
wanted to say?

> Signed-off-by: Shi junming <junming@xxxxxxxxxxxx>
> ---
>  tools/power/acpi/tools/pfrut/pfrut.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/power/acpi/tools/pfrut/pfrut.c b/tools/power/acpi/tools/pfrut/pfrut.c
> index d79c335594b2..52aa0351533c 100644
> --- a/tools/power/acpi/tools/pfrut/pfrut.c
> +++ b/tools/power/acpi/tools/pfrut/pfrut.c
> @@ -190,7 +190,7 @@ int main(int argc, char *argv[])
>         void *addr_map_capsule;
>         struct stat st;
>         char *log_buf;
> -       int ret = 0;
> +       int ret;
>
>         if (getuid() != 0) {
>                 printf("Please run the tool as root - Exiting.\n");
> --
> 2.18.2
>