Re: [PATCH 5.19] mt76: mt7921: fix command timeout in AP stop period

From: Greg KH
Date: Thu Aug 25 2022 - 07:59:22 EST


On Thu, Aug 25, 2022 at 11:27:22AM +0800, sean.wang@xxxxxxxxxxxx wrote:
> From: Deren Wu <deren.wu@xxxxxxxxxxxx>
>
> commit 9d958b60ebc2434f2b7eae83d77849e22d1059eb upstream.
>
> Due to AP stop improperly, mt7921 driver would face random command timeout
> by chip fw problem. Migrate AP start/stop process to .start_ap/.stop_ap and
> congiure BSS network settings in both hooks.
>
> The new flow is shown below.
> * AP start
> .start_ap()
> configure BSS network resource
> set BSS to connected state
> .bss_info_changed()
> enable fw beacon offload
>
> * AP stop
> .bss_info_changed()
> disable fw beacon offload (skip this command)
> .stop_ap()
> set BSS to disconnected state (beacon offload disabled automatically)
> destroy BSS network resource
>
> Fixes: 116c69603b01 ("mt76: mt7921: Add AP mode support")
> Signed-off-by: Sean Wang <sean.wang@xxxxxxxxxxxx>
> Signed-off-by: Deren Wu <deren.wu@xxxxxxxxxxxx>
> Signed-off-by: Felix Fietkau <nbd@xxxxxxxx>
> ---
> .../wireless/mediatek/mt76/mt76_connac_mcu.c | 2 +
> .../net/wireless/mediatek/mt76/mt7921/main.c | 47 +++++++++++++++----
> .../net/wireless/mediatek/mt76/mt7921/mcu.c | 5 +-
> .../wireless/mediatek/mt76/mt7921/mt7921.h | 2 +
> 4 files changed, 43 insertions(+), 13 deletions(-)

Now queued up, thanks,

greg k-h