On Thu, Aug 25, 2022 at 04:41:37PM +0800, Gaosheng Cui wrote:
The crypto_alloc_test_larval() will return null if manager is disabled,A NULL indicates success, why are you jumping to the error path?
it may not return error pointers, so using IS_ERR_OR_NULL()
to check the return value to fix this.
The __crypto_register_alg() will return null if manager is disabled,
it may not return error pointers, so using IS_ERR_OR_NULL()
to check the return value to fix this.
Fixes: cad439fc040e ("crypto: api - Do not create test larvals if manager is disabled")
Signed-off-by: Gaosheng Cui <cuigaosheng1@xxxxxxxxxx>
---
crypto/algapi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/crypto/algapi.c b/crypto/algapi.c
index 5c69ff8e8fa5..5a080b8aaa11 100644
--- a/crypto/algapi.c
+++ b/crypto/algapi.c
@@ -283,7 +283,7 @@ static struct crypto_larval *__crypto_register_alg(struct crypto_alg *alg)
}
larval = crypto_alloc_test_larval(alg);
- if (IS_ERR(larval))
+ if (IS_ERR_OR_NULL(larval))
goto out;
Cheers,