Re: [PATCH RESEND v10 6/7] clk: baikal-t1: Add DDR/PCIe directly controlled resets support

[Serge Semin]

On Tue, Aug 23, 2022 at 01:23:32PM +0300, Krzysztof Kozlowski wrote:
> On 22/08/2022 21:29, Serge Semin wrote:
> > Aside with a set of the trigger-like resets Baikal-T1 CCU provides two
> > additional blocks with directly controlled reset signals. In particular it
> > concerns DDR full and initial resets and various PCIe sub-domains resets.
> > Let's add the direct reset assertion/de-assertion of the corresponding
> > flags support into the Baikal-T1 CCU driver then. It will be required at
> > least for the PCIe platform driver. Obviously the DDR controller isn't
> > supposed to be fully reset in the kernel, so the corresponding controls
> > are added just for the sake of the interface implementation completeness.
> > 
> > Signed-off-by: Serge Semin <Sergey.Semin@xxxxxxxxxxxxxxxxxxxx>
> > Reviewed-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> > 
> > ---
> > 
> > Changelog v6:
> > - Refactor the code to support the linear reset IDs only. (@Philipp)
> > 
> > Changelog v7:
> > - Drop empty line from the sys_rst_info structure initialization block.
> >   (@Philipp)
> > ---
> >  drivers/clk/baikal-t1/ccu-rst.c     | 66 +++++++++++++++++++++++++++++
> >  drivers/clk/baikal-t1/ccu-rst.h     | 10 +++++
> >  include/dt-bindings/reset/bt1-ccu.h |  9 ++++
> 

> Do not mix drivers and bindings. Bindings always go separately, so this
> has to be split.

Ok. Sigh...

-Sergey

> 
> Best regards,
> Krzysztof