Re: [RFC PATCH] usb: reduce kernel log spam on driver registration

From: Rob Herring
Date: Thu Aug 25 2022 - 15:59:43 EST


On Thu, Aug 25, 2022 at 12:04 PM Ard Biesheuvel <ardb@xxxxxxxxxx> wrote:
>
> Drivers are typically supposed to be quiet unless they are actually
> probed, but for some reason, USB host controllers seem to be exempt from
> this rule, and happily broadcast their existence into the kernel log at
> boot even if the hardware in question is nowhere to be found.
>
> Let's fix that, and remove these pr_info() calls.
>
> Cc: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: Nicolas Ferre <nicolas.ferre@xxxxxxxxxxxxx>
> Cc: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>
> Cc: Claudiu Beznea <claudiu.beznea@xxxxxxxxxxxxx>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Cc: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>
> Cc: Avi Fishman <avifishman70@xxxxxxxxx>
> Cc: Tomer Maimon <tmaimon77@xxxxxxxxx>
> Cc: Tali Perry <tali.perry1@xxxxxxxxx>
> Cc: Patrick Venture <venture@xxxxxxxxxx>
> Cc: Nancy Yuen <yuenn@xxxxxxxxxx>
> Cc: Benjamin Fair <benjaminfair@xxxxxxxxxx>
> Cc: Patrice Chotard <patrice.chotard@xxxxxxxxxxx>
> Cc: Vladimir Zapolskiy <vz@xxxxxxxxx>
> Cc: linux-usb@xxxxxxxxxxxxxxx
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Cc: linux-samsung-soc@xxxxxxxxxxxxxxx
> Cc: linux-omap@xxxxxxxxxxxxxxx
> Signed-off-by: Ard Biesheuvel <ardb@xxxxxxxxxx>
> ---
> drivers/usb/host/ehci-atmel.c | 1 -
> drivers/usb/host/ehci-exynos.c | 1 -
> drivers/usb/host/ehci-fsl.c | 2 --
> drivers/usb/host/ehci-hcd.c | 1 -
> drivers/usb/host/ehci-npcm7xx.c | 2 --
> drivers/usb/host/ehci-omap.c | 2 --
> drivers/usb/host/ehci-orion.c | 2 --
> drivers/usb/host/ehci-pci.c | 2 --
> drivers/usb/host/ehci-platform.c | 2 --
> drivers/usb/host/ehci-spear.c | 2 --
> drivers/usb/host/ehci-st.c | 2 --
> drivers/usb/host/fotg210-hcd.c | 1 -
> drivers/usb/host/ohci-at91.c | 1 -
> drivers/usb/host/ohci-da8xx.c | 1 -
> drivers/usb/host/ohci-exynos.c | 1 -
> drivers/usb/host/ohci-hcd.c | 1 -
> drivers/usb/host/ohci-nxp.c | 2 --
> drivers/usb/host/ohci-omap.c | 2 --
> drivers/usb/host/ohci-pci.c | 2 --
> drivers/usb/host/ohci-platform.c | 2 --
> drivers/usb/host/ohci-pxa27x.c | 2 --
> drivers/usb/host/ohci-s3c2410.c | 1 -
> drivers/usb/host/ohci-spear.c | 2 --
> drivers/usb/host/ohci-st.c | 2 --
> 24 files changed, 39 deletions(-)

Reviewed-by: Rob Herring <robh@xxxxxxxxxx>

I've had the same patch sitting around since 3.15...

Rob