Re: [PATCH] phy: move from strlcpy with unused retval to strscpy

[Jernej Škrabec]

Dne četrtek, 18. avgust 2022 ob 23:00:56 CEST je Wolfram Sang napisal(a):
> Follow the advice of the below link and prefer 'strscpy' in this
> subsystem. Conversion is 1:1 because the return value is not used.
> Generated by a coccinelle script.
> 
> Link:
> https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmk
> nw@xxxxxxxxxxxxxx/ Signed-off-by: Wolfram Sang
> <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>

Acked-by: Jernej Skrabec <jernej.skrabec@xxxxxxxxx>

Best regards,
Jernej

> ---
>  drivers/phy/allwinner/phy-sun4i-usb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/phy/allwinner/phy-sun4i-usb.c
> b/drivers/phy/allwinner/phy-sun4i-usb.c index d5f3b42eb8ce..3a3831f6059a
> 100644
> --- a/drivers/phy/allwinner/phy-sun4i-usb.c
> +++ b/drivers/phy/allwinner/phy-sun4i-usb.c
> @@ -768,7 +768,7 @@ static int sun4i_usb_phy_probe(struct platform_device
> *pdev) if (data->cfg->dedicated_clocks)
>  			snprintf(name, sizeof(name), "usb%d_phy", 
i);
>  		else
> -			strlcpy(name, "usb_phy", sizeof(name));
> +			strscpy(name, "usb_phy", sizeof(name));
> 
>  		phy->clk = devm_clk_get(dev, name);
>  		if (IS_ERR(phy->clk)) {
> --
> 2.35.1