Re: [PATCH v12 05/13] nvme: zns: Allow ZNS drives that have non-power_of_2 zone size

From: Bart Van Assche
Date: Thu Aug 25 2022 - 17:48:38 EST


On 8/23/22 05:18, Pankaj Raghav wrote:
Remove the condition which disallows non-power_of_2 zone size ZNS drive
to be updated and use generic method to calculate number of zones
instead of relying on log and shift based calculation on zone size.

The power_of_2 calculation has been replaced directly with generic
calculation without special handling. Both modified functions are not
used in hot paths, they are only used during initialization &
revalidation of the ZNS device.

As rounddown macro from math.h does not work for 32 bit architectures,
round down operation is open coded.

Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>