Re: [PATCH -next 2/3] remoteproc: qcom: wcss: Use devm_platform_ioremap_resource_byname()

[Mukesh Ojha]

On 8/26/2022 7:15 AM, Yang Yingliang wrote:
> Use the devm_platform_ioremap_resource_byname() helper instead of
> calling platform_get_resource_byname() and devm_ioremap_resource()
> separately.
>
> Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>
> ---
>   drivers/remoteproc/qcom_q6v5_wcss.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/remoteproc/qcom_q6v5_wcss.c b/drivers/remoteproc/qcom_q6v5_wcss.c
> index 017ee225dc32..209fc1bd1424 100644
> --- a/drivers/remoteproc/qcom_q6v5_wcss.c
> +++ b/drivers/remoteproc/qcom_q6v5_wcss.c
> @@ -835,8 +835,7 @@ static int q6v5_wcss_init_mmio(struct q6v5_wcss *wcss,
>   		return -ENOMEM;
>   
>   	if (wcss->version == WCSS_IPQ8074) {
> -		res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "rmb");
> -		wcss->rmb_base = devm_ioremap_resource(&pdev->dev, res);
> +		wcss->rmb_base = devm_platform_ioremap_resource_byname(pdev, "rmb");

LGTM.

Reviewed-by:Mukesh Ojha <quic_mojha@xxxxxxxxxxx>

-Mukesh


>   		if (IS_ERR(wcss->rmb_base))
>   			return PTR_ERR(wcss->rmb_base);
>   	}