Re: [PATCH] char: move from strlcpy with unused retval to strscpy

[Jarkko Sakkinen]

On Thu, Aug 18, 2022 at 10:59:59PM +0200, Wolfram Sang wrote:
> Follow the advice of the below link and prefer 'strscpy' in this
> subsystem. Conversion is 1:1 because the return value is not used.
> Generated by a coccinelle script.
> 
> Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@xxxxxxxxxxxxxx/
> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
> ---
>  drivers/char/tpm/tpm_ppi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/char/tpm/tpm_ppi.c b/drivers/char/tpm/tpm_ppi.c
> index 40018a73b3cb..bc7b1b4501b3 100644
> --- a/drivers/char/tpm/tpm_ppi.c
> +++ b/drivers/char/tpm/tpm_ppi.c
> @@ -380,7 +380,7 @@ void tpm_add_ppi(struct tpm_chip *chip)
>  				      TPM_PPI_FN_VERSION,
>  				      NULL, ACPI_TYPE_STRING);
>  	if (obj) {
> -		strlcpy(chip->ppi_version, obj->string.pointer,
> +		strscpy(chip->ppi_version, obj->string.pointer,
>  			sizeof(chip->ppi_version));
>  		ACPI_FREE(obj);
>  	}
> -- 
> 2.35.1
> 

I can cope with this.

Reviewed-by: Jarkko Sakkinen <jarkko@xxxxxxxxxx>

BR, Jarkko