Re: [PATCH v2 1/2] dt-bindings: lan9662-otpc: document Lan9662 OTPC

From: Krzysztof Kozlowski
Date: Fri Aug 26 2022 - 02:42:22 EST


On 25/08/2022 23:40, Horatiu Vultur wrote:
> Document Lan9662 OTP controller.
>
> Signed-off-by: Horatiu Vultur <horatiu.vultur@xxxxxxxxxxxxx>
> ---
> .../nvmem/microchip,lan9662-otpc.yaml | 42 +++++++++++++++++++
> 1 file changed, 42 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/nvmem/microchip,lan9662-otpc.yaml
>
> diff --git a/Documentation/devicetree/bindings/nvmem/microchip,lan9662-otpc.yaml b/Documentation/devicetree/bindings/nvmem/microchip,lan9662-otpc.yaml
> new file mode 100644
> index 000000000000..3307f6a7a373
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/nvmem/microchip,lan9662-otpc.yaml
> @@ -0,0 +1,42 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/nvmem/microchip,lan9662-otpc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Microchip LAN9662 OTP Controller (OTPC)
> +
> +maintainers:
> + - Horatiu Vultur <horatiu.vultur@xxxxxxxxxxxxx>
> +
> +description: |
> + OTP controller drives a NVMEM memory where system specific data
> + (e.g. hardware configuration settings, chip identifiers) or
> + user specific data could be stored.
> +
> +allOf:
> + - $ref: nvmem.yaml#
> +
> +properties:
> + compatible:
> + items:
> + - const: microchip,lan9662-otpc
> + - const: microchip,lan9668-otpc

Does not look like you tested the bindings. Please run `make
dt_binding_check` (see
Documentation/devicetree/bindings/writing-schema.rst for instructions).

This won't work...

Best regards,
Krzysztof