Re: [PATCH V4] mm: fix use-after free of page_ext after race with memory-offline

From: Charan Teja Kalla
Date: Fri Aug 26 2022 - 03:53:01 EST


Hi David,

On 8/23/2022 10:35 PM, Charan Teja Kalla wrote:
>> I kind-of dislike the "loop" labels. Can we come up with a more
>> expressive name?
>>
>> "put_continue"
>>
>> or something?
>>
>>
>> One alternative would be to add to the beginning of the loop, and after
>> the loop sth like
>>
>> if (page_ext) {
>> page_ext_put(page_ext);
>> page_ext = NULL;
>> }
> I think, moving this to beginning of the loop looks cleaner than the
> goto statement. Will spin V5.
>
I have realized that goto looks simpler and cleaner... Raised V5 @
https://lore.kernel.org/all/1661496993-11473-1-git-send-email-quic_charante@xxxxxxxxxxx/
>