Re: [PATCH 0/3] serial: Add uart_xmit_advance() + fixes part (of a larger patch series)

From: Andy Shevchenko
Date: Fri Aug 26 2022 - 12:04:35 EST


On Thu, Aug 25, 2022 at 12:19 PM Ilpo Järvinen
<ilpo.jarvinen@xxxxxxxxxxxxxxx> wrote:
>
> Add uart_xmit_advance() helper to handle circular xmit buffer
> advancement + accounting of Tx'ed bytes. Use it to fix a few drivers
> that previously lacked to accounting for DMA Tx.

For the whole series
Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
Thanks for fixing this issue.

> Greg,
> I've a another series on top this which is tty-next material making the
> rest of the drivers to use uart_xmit_advance(). That series obviously
> depends on the patch 1/3 of this series so if you end up putting these
> 3 patches into tty-linus, I'll need it to be merged into tty-next at
> some point (I'm not in a big hurry with this so if you choose to delay
> the merge, it's not a big deal).
>
> Ilpo Järvinen (3):
> serial: Create uart_xmit_advance()
> serial: tegra: Use uart_xmit_advance(), fixes icount.tx accounting
> serial: tegra-tcu: Use uart_xmit_advance(), fixes icount.tx accounting
>
> drivers/tty/serial/serial-tegra.c | 5 ++---
> drivers/tty/serial/tegra-tcu.c | 2 +-
> include/linux/serial_core.h | 17 +++++++++++++++++
> 3 files changed, 20 insertions(+), 4 deletions(-)
>
> --
> 2.30.2
>


--
With Best Regards,
Andy Shevchenko