Re: [PATCH] arm64: dts: qcom: sc7280-herobrine: Don't enable the USB 2.0 port

[Doug Anderson]

 Hi,

On Fri, Aug 26, 2022 at 8:48 AM Matthias Kaehlcke <mka@xxxxxxxxxxxx> wrote:
>
> The USB 2.0 port of sc7280 is currently not used by any herobrine
> board. Delete the device tree entries that enable it.
>
> Signed-off-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx>
> ---
> I was also told that the 2.0 port is for the Embedded USB Debugger
> (EUD) only, but I'm not sure if that's true. From the Linux side
> it looks like a regular dwc3 controller.
>
>  arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 12 ------------
>  1 file changed, 12 deletions(-)

I can confirm it's not hooked up anywhere on herobrine-class boards.
Disabling looks good to me. If we later have a herobrine variant where
this is enabled we can enable it just for that variant.

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>