Re: [PATCH -next 3/3] clk: sunxi-ng: ccu-sun9i-a80-usb: Use dev_err_probe() helper

From: Jernej Škrabec
Date: Sat Aug 27 2022 - 07:07:49 EST


Dne sobota, 27. avgust 2022 ob 11:41:51 CEST je Yang Yingliang napisal(a):
> dev_err() can be replace with dev_err_probe() which will check if error
> code is -EPROBE_DEFER.
>
> Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>

Reviewed-by: Jernej Skrabec <jernej.skrabec@xxxxxxxxx>

Best regards,
Jernej

> ---
> drivers/clk/sunxi-ng/ccu-sun9i-a80-usb.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/clk/sunxi-ng/ccu-sun9i-a80-usb.c
> b/drivers/clk/sunxi-ng/ccu-sun9i-a80-usb.c index 575ae4ccc65f..a0fb0da8f356
> 100644
> --- a/drivers/clk/sunxi-ng/ccu-sun9i-a80-usb.c
> +++ b/drivers/clk/sunxi-ng/ccu-sun9i-a80-usb.c
> @@ -101,12 +101,9 @@ static int sun9i_a80_usb_clk_probe(struct
> platform_device *pdev) return PTR_ERR(reg);
>
> bus_clk = devm_clk_get(&pdev->dev, "bus");
> - if (IS_ERR(bus_clk)) {
> - ret = PTR_ERR(bus_clk);
> - if (ret != -EPROBE_DEFER)
> - dev_err(&pdev->dev, "Couldn't get bus clk:
%d\n", ret);
> - return ret;
> - }
> + if (IS_ERR(bus_clk))
> + return dev_err_probe(&pdev->dev, PTR_ERR(bus_clk),
> + "Couldn't get bus clk\n");
>
> /* The bus clock needs to be enabled for us to access the
registers */
> ret = clk_prepare_enable(bus_clk);