drivers/message/fusion/mptctl.c:1494:9: warning: 'strncpy' specified bound 12 equals destination size
From: kernel test robot
Date: Sun Aug 28 2022 - 18:21:36 EST
Hi Ilya,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 8379c0b31fbc5d20946f617f8e2fe4791e6f58c1
commit: e37b3dd063a1a68e28a7cfaf77c84c472112e330 s390: enable KCSAN
date: 1 year, 1 month ago
config: s390-randconfig-r004-20220829 (https://download.01.org/0day-ci/archive/20220829/202208290627.EFFCtUl5-lkp@xxxxxxxxx/config)
compiler: s390-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e37b3dd063a1a68e28a7cfaf77c84c472112e330
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout e37b3dd063a1a68e28a7cfaf77c84c472112e330
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash drivers/message/fusion/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All warnings (new ones prefixed by >>):
drivers/message/fusion/mptctl.c: In function 'mptctl_hp_hostinfo':
drivers/message/fusion/mptctl.c:2329:33: warning: variable 'retval' set but not used [-Wunused-but-set-variable]
2329 | int retval;
| ^~~~~~
In function 'mptctl_readtest',
inlined from '__mptctl_ioctl.isra' at drivers/message/fusion/mptctl.c:661:10:
>> drivers/message/fusion/mptctl.c:1494:9: warning: 'strncpy' specified bound 12 equals destination size [-Wstringop-truncation]
1494 | strncpy (karg.product, ioc->prod_name, MPT_PRODUCT_LENGTH);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/strncpy +1494 drivers/message/fusion/mptctl.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 1459
^1da177e4c3f41 Linus Torvalds 2005-04-16 1460 /*=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=*/
^1da177e4c3f41 Linus Torvalds 2005-04-16 1461 /* MPT IOCTL Test function.
^1da177e4c3f41 Linus Torvalds 2005-04-16 1462 *
^1da177e4c3f41 Linus Torvalds 2005-04-16 1463 * Outputs: None.
^1da177e4c3f41 Linus Torvalds 2005-04-16 1464 * Return: 0 if successful
^1da177e4c3f41 Linus Torvalds 2005-04-16 1465 * -EFAULT if data unavailable
^1da177e4c3f41 Linus Torvalds 2005-04-16 1466 * -ENODEV if no such device/adapter
^1da177e4c3f41 Linus Torvalds 2005-04-16 1467 */
^1da177e4c3f41 Linus Torvalds 2005-04-16 1468 static int
28d76df18f0ad5 Dan Carpenter 2020-01-14 1469 mptctl_readtest (MPT_ADAPTER *ioc, unsigned long arg)
^1da177e4c3f41 Linus Torvalds 2005-04-16 1470 {
^1da177e4c3f41 Linus Torvalds 2005-04-16 1471 struct mpt_ioctl_test __user *uarg = (void __user *) arg;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1472 struct mpt_ioctl_test karg;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1473
^1da177e4c3f41 Linus Torvalds 2005-04-16 1474 if (copy_from_user(&karg, uarg, sizeof(struct mpt_ioctl_test))) {
29dd3609f2fc70 Eric Moore 2007-09-14 1475 printk(KERN_ERR MYNAM "%s@%d::mptctl_readtest - "
^1da177e4c3f41 Linus Torvalds 2005-04-16 1476 "Unable to read in mpt_ioctl_test struct @ %p\n",
^1da177e4c3f41 Linus Torvalds 2005-04-16 1477 __FILE__, __LINE__, uarg);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1478 return -EFAULT;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1479 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 1480
09120a8cd38dbd Prakash, Sathya 2007-07-24 1481 dctlprintk(ioc, printk(MYIOC_s_DEBUG_FMT "mptctl_readtest called.\n",
09120a8cd38dbd Prakash, Sathya 2007-07-24 1482 ioc->name));
^1da177e4c3f41 Linus Torvalds 2005-04-16 1483 /* Fill in the data and return the structure to the calling
^1da177e4c3f41 Linus Torvalds 2005-04-16 1484 * program
^1da177e4c3f41 Linus Torvalds 2005-04-16 1485 */
^1da177e4c3f41 Linus Torvalds 2005-04-16 1486
^1da177e4c3f41 Linus Torvalds 2005-04-16 1487 #ifdef MFCNT
^1da177e4c3f41 Linus Torvalds 2005-04-16 1488 karg.chip_type = ioc->mfcnt;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1489 #else
^1da177e4c3f41 Linus Torvalds 2005-04-16 1490 karg.chip_type = ioc->pcidev->device;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1491 #endif
^1da177e4c3f41 Linus Torvalds 2005-04-16 1492 strncpy (karg.name, ioc->name, MPT_MAX_NAME);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1493 karg.name[MPT_MAX_NAME-1]='\0';
^1da177e4c3f41 Linus Torvalds 2005-04-16 @1494 strncpy (karg.product, ioc->prod_name, MPT_PRODUCT_LENGTH);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1495 karg.product[MPT_PRODUCT_LENGTH-1]='\0';
^1da177e4c3f41 Linus Torvalds 2005-04-16 1496
^1da177e4c3f41 Linus Torvalds 2005-04-16 1497 /* Copy the data from kernel memory to user memory
^1da177e4c3f41 Linus Torvalds 2005-04-16 1498 */
^1da177e4c3f41 Linus Torvalds 2005-04-16 1499 if (copy_to_user((char __user *)arg, &karg, sizeof(struct mpt_ioctl_test))) {
29dd3609f2fc70 Eric Moore 2007-09-14 1500 printk(MYIOC_s_ERR_FMT "%s@%d::mptctl_readtest - "
^1da177e4c3f41 Linus Torvalds 2005-04-16 1501 "Unable to write out mpt_ioctl_test struct @ %p\n",
29dd3609f2fc70 Eric Moore 2007-09-14 1502 ioc->name, __FILE__, __LINE__, uarg);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1503 return -EFAULT;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1504 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 1505
^1da177e4c3f41 Linus Torvalds 2005-04-16 1506 return 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1507 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 1508
:::::: The code at line 1494 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2
:::::: TO: Linus Torvalds <torvalds@xxxxxxxxxxxxxxx>
:::::: CC: Linus Torvalds <torvalds@xxxxxxxxxxxxxxx>
--
0-DAY CI Kernel Test Service
https://01.org/lkp