Re: [PATCH net] net/smc: Remove redundant refcount increase

[Tony Lu]

On Mon, Aug 29, 2022 at 10:53:29PM +0800, liuyacan@xxxxxxxxxxxxxxxx wrote:
> From: liuyacan <liuyacan@xxxxxxxxxxxxxxxx>
> 
> For passive connections, the refcount increment has been done in
> smc_clcsock_accept()-->smc_sock_alloc().
> 
> Fixes: 3b2dec2603d5("net/smc: restructure client and server code in af_smc")
> Signed-off-by: liuyacan <liuyacan@xxxxxxxxxxxxxxxx>
> ---
>  net/smc/af_smc.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c
> index 79c1318af..0939cc3b9 100644
> --- a/net/smc/af_smc.c
> +++ b/net/smc/af_smc.c
> @@ -1855,7 +1855,6 @@ static void smc_listen_out_connected(struct smc_sock *new_smc)
>  {
>  	struct sock *newsmcsk = &new_smc->sk;
>  
> -	sk_refcnt_debug_inc(newsmcsk);
>  	if (newsmcsk->sk_state == SMC_INIT)

Thank you for the fixes, I will test it in the CI.

Thanks.
Tony Lu