Re: [PATCH 2/3] serial: sh-sci: tail is already on valid range

[Jiri Slaby]

On 23. 08. 22, 16:18, Ilpo Järvinen wrote:
> There is no need to and tail with UART_XMIT_SIZE - 1 because tail is
> already on valid range.

Reviewed-by: Jiri Slaby <jirislaby@xxxxxxxxxx>

> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
> ---
>   drivers/tty/serial/sh-sci.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
> index 6d2f5a08ff1f..2ddcd7eec71e 100644
> --- a/drivers/tty/serial/sh-sci.c
> +++ b/drivers/tty/serial/sh-sci.c
> @@ -1407,7 +1407,7 @@ static void sci_dma_tx_work_fn(struct work_struct *work)
>   	spin_lock_irq(&port->lock);
>   	head = xmit->head;
>   	tail = xmit->tail;
> -	buf = s->tx_dma_addr + (tail & (UART_XMIT_SIZE - 1));
> +	buf = s->tx_dma_addr + tail;
>   	s->tx_dma_len = CIRC_CNT_TO_END(head, tail, UART_XMIT_SIZE);
>   	if (!s->tx_dma_len) {
>   		/* Transmit buffer has been flushed */

--
js
suse labs