Re: [PATCH 2/3] openrisc: ptrace: Remove duplicate operation

From: Stafford Horne
Date: Tue Aug 30 2022 - 03:34:02 EST


On Tue, Aug 30, 2022 at 02:53:15AM -0400, guoren@xxxxxxxxxx wrote:
> From: Guo Ren <guoren@xxxxxxxxxxxxxxxxx>
>
> The TIF_SYSCALL_TRACE is controlled by a common code, see
> kernel/ptrace.c and include/linux/thread.h.
>
> clear_task_syscall_work(child, SYSCALL_TRACE);
>
> Signed-off-by: Guo Ren <guoren@xxxxxxxxxxxxxxxxx>
> Signed-off-by: Guo Ren <guoren@xxxxxxxxxx>

Acked-by: Stafford Horne <shorne@xxxxxxxxx>

> ---
> arch/openrisc/kernel/ptrace.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/openrisc/kernel/ptrace.c b/arch/openrisc/kernel/ptrace.c
> index b971740fc2aa..cc53fa676706 100644
> --- a/arch/openrisc/kernel/ptrace.c
> +++ b/arch/openrisc/kernel/ptrace.c
> @@ -132,7 +132,6 @@ void ptrace_disable(struct task_struct *child)
> pr_debug("ptrace_disable(): TODO\n");
>
> user_disable_single_step(child);
> - clear_tsk_thread_flag(child, TIF_SYSCALL_TRACE);
> }
>
> long arch_ptrace(struct task_struct *child, long request, unsigned long addr,
> --
> 2.36.1
>