Re: [PATCH v4] regulator: dt-bindings: mediatek: add mt6366

[Krzysztof Kozlowski]

On 29/08/2022 06:25, zhiyong.tao wrote:
>>> +properties:
>>> +  compatible:
>>> +    const: mediatek,mt6366-regulator
>>
>> This looks incomplete. How does it bind? Further pieces also suggest
>> you
>> send something incomplete.
> ==>
> 
> The project dts file(such as 8186-evb.dts) will add the compatible.
> The project dts file is examining.
> 

I don't understand this at all. I am not talking about DTS, but about
bindings which look incomplete. Although seeing entire DTS would
probably help understand the context.

(...)

>>
>>
>>> +        type: object
>>> +        $ref: regulator.yaml#
>>> +        unevaluatedProperties: false
>>> +
>>> +required:
>>> +  - compatible
>>> +  - regulators
>>> +
>>> +additionalProperties: false
>>> +
>>> +examples:

>>> +  - |
>>> +    pmic {
>>> +        compatible = "mediatek,mt6366-regulator";
>>> +
>>> +        regulators {
>>> +            mt6366_vdram1_reg: buck-vdram1 {
>>
>> Drop the labels here and further. Why you do not have here any
>> regular
>> constraints like min/max voltage?
> 
> we will add properties min/max voltag on project dts file.

Example should be complete. DTS does not matter here.

> 
>>
>>> +                regulator-ramp-delay = <12500>;
>>> +                regulator-enable-ramp-delay = <0>;
>>> +                regulator-allowed-modes = <0 1>;
>>
>> Where do you explain the meaning of modes?
> support pwm mode.

The question was "Where". Where did you explain them?

(...)

>>> +
>>> +            mt6366_vsim2_reg: ldo-vsim2 {
>>> +                regulator-enable-ramp-delay = <540>;
>>> +            };
>>> +
>>> +            mt6366_vcore_sshub_reg: buck-vcore-sshub {
>>
>> Empty node? What does it do?
> just define here, we will add properties on project dts file.

How is it related to bindings?

Best regards,
Krzysztof