Re: [PATCHv2 resend] dt-bindings: leds: Expand LED_COLOR_ID definitions
From: Krzysztof Kozlowski
Date: Tue Aug 30 2022 - 04:38:11 EST
On 30/08/2022 11:30, Olliver Schinagl wrote:
> Hey all,
>
> On 29-08-2022 17:13, Rob Herring wrote:
>> On Mon, Aug 29, 2022 at 04:12:00PM +0200, Alexander Dahl wrote:
>>> Hei Olliver,
>>>
>>> Am Fri, Aug 19, 2022 at 05:29:04PM +0200 schrieb Olliver Schinagl:
>>>> In commit 853a78a7d6c7 (dt-bindings: leds: Add LED_COLOR_ID definitions,
>>>> Sun Jun 9 20:19:04 2019 +0200) the most basic color definitions where
>>>> added. However, there's a little more very common LED colors.
>>>>
>>>> While the documentation states 'add what is missing', engineers tend to
>>>> be lazy and will just use what currently exists. So this patch will take
>>>> (a) list from online retailers [0], [1], [2] and use the common LED colors
>>>> from there, this being reasonable as this is what is currently available to
>>>> purchase.
>>>>
>>>> Note, that LIME seems to be the modern take to 'Yellow-green' or
>>>> 'Yellowish-green' from some older datasheets.
>>> Just noticed you did not send this to neither linux-leds mailing list
>>> nor the LED subsystem maintainer. Maybe you want to do this in v3?
>> Yes, please do. If Pavel doesn't pick up v3 in a timely manor, then I
>> will.
>>
>> Rob
>
> Sorry to both, get_maintainers didn't pop those up!
Indeed, I sent a fix for this.
>
> As Krzyzstof Acked the v2, and no comments for a v3 have been proposed,
> would that be a changeless v3 just to involve all parties?
Yeah, just resend with get_maintainers output based on
Documentation/devicetree/bindings/leds/ (or on top of my patch).
Best regards,
Krzysztof